1.1.7 rlm_detail locking is broken
aland at deployingradius.com
Mon Nov 26 21:59:36 CET 2007
Brian De Wolf wrote:
> I recently installed freeradius and have it forwarding accounting information.
> I noticed that there were a lot of failed locks in the logs, so I began to
> investigate. In rlm_detail, I found this loop for locking:
> It looks like the locking should work perfectly! But it seems these changes
> never found their way into the 1.x series, despite having occurred two years
> ago. I poked around in CVS and found revision 1.43 which is when the corrected
> locking was added. I took a diff of revision 1.42 and 1.43, and applied it by
> hand to 1.1.7. I haven't had any complaints from freeradius about locking
> issues since.
Thanks. I've committed the patch.
> I have attached the patch. Is there any reason this never found its way into
> the 1.x series? I see it's in the CVS head.
Some things just get missed.
More information about the Freeradius-Devel